Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bottom padding to code editor #18368

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

joshmcrty
Copy link
Contributor

Proposed change

Adds bottom padding to the code editor so horizontal scrollbars do not cover up the last line of code when they appear. This is notable on macOS using a trackpad with the "Show scroll bars" setting set to "Automatically based on mouse or trackpad". This matches the top padding for the code editor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Open the Developer Tools > Template tab on macOS with the scrollbar setting mentioned above and then use the trackpad to scroll horizontally. A scrollbar will appear and cover the bottom line of code in the editor.

Screen.Recording.2023-10-23.at.1.12.37.PM.mov

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 18827db into home-assistant:dev Oct 24, 2023
14 checks passed
@joshmcrty joshmcrty deleted the codemirror-bottom-padding branch October 24, 2023 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horizontal scrollbar in dev tools template covers template
2 participants