Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to create local calendar in calendar panel #18377

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya
Copy link
Member

piitaya commented Oct 24, 2023

Should we add some margin at the bottom? It feel weird and cropped (even it's not the case)

CleanShot 2023-10-24 at 18 16 28

@bramkragten
Copy link
Member Author

We can make it higher, I think adding margin is a bit weird

@piitaya
Copy link
Member

piitaya commented Oct 24, 2023

I think it's because of the username not aligned next to it. But we can improve the design during beta.

@bramkragten bramkragten merged commit ccba7a7 into dev Oct 24, 2023
14 checks passed
@bramkragten bramkragten deleted the create-calendar branch October 24, 2023 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants