Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize observer to full calendar, fix missing styles #18381

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

bramkragten
Copy link
Member

Proposed change

Fixes bugs in full calendar, after re connecting it would no longer have styles, and it didnt react to resizes.
This solves those issues.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 🙂

@bramkragten bramkragten merged commit 2b67731 into dev Oct 24, 2023
12 checks passed
@bramkragten bramkragten deleted the resize-observer-full-calendar branch October 24, 2023 17:33
@karwosts
Copy link
Contributor

Looks like ha-schedule-form still has some issues, I hoped this would fix this but it looks like it didn't. Maybe needs a similar fix.

#17910

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants