Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev tools events layout #18389

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

joshmcrty
Copy link
Contributor

Proposed change

This PR cleans up the layout of the Developer Tools > Events page. There currently are a few areas with missing or inconsistent spacing, and at certain screen widths part of the page will be cut off and cause horizontal scrolling if there are events with long lines of text.

Here is the current layout with issues indicated:

Screenshot 2023-10-24 at 2 45 29 PM

Screenshot 2023-10-24 at 2 46 28 PM

Here is the page after this PR. Note that the individual event code elements will now scroll horizontally instead of the entire page.

Screenshot 2023-10-24 at 2 51 39 PM

Screenshot 2023-10-24 at 2 51 26 PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Go to the Developer Tools > Events page to view the layout. Listen to some events (for example "*"). Resize the screen width until just before it breaks into a mobile/vertical layout to see possible horizontal scrolling before this fix.

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

bramkragten
bramkragten previously approved these changes Nov 29, 2023
@bramkragten bramkragten enabled auto-merge (squash) November 29, 2023 09:43
@bramkragten bramkragten merged commit eda0d12 into home-assistant:dev Nov 29, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants