-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mac and bluetooth address to the device info card #18392
Merged
bramkragten
merged 3 commits into
home-assistant:dev
from
jpbede:device-info-mac-bluetooth
Oct 25, 2023
Merged
Add mac and bluetooth address to the device info card #18392
bramkragten
merged 3 commits into
home-assistant:dev
from
jpbede:device-info-mac-bluetooth
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
reviewed
Oct 25, 2023
piitaya
reviewed
Oct 25, 2023
Co-authored-by: Paul Bottein <[email protected]>
bramkragten
approved these changes
Oct 25, 2023
20 tasks
You need to re-add the device as BTHome lacks those informations. They've been added recently to BTHome and Xiaomi BLE (home-assistant/core#102773) Besides, please create a issue for something like this, a closed PR isn't the right place to track this :) |
My apologies, before opening an issue I wanted to make sure I was doing the right thing. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
As mentioned and requested by @bdraco in #18386, also show the Mac and Bluetooth address in the device info card. I hope my approach is ok.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: