Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mac and bluetooth address to the device info card #18392

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Oct 25, 2023

Proposed change

As mentioned and requested by @bdraco in #18386, also show the Mac and Bluetooth address in the device info card. I hope my approach is ok.

CleanShot 2023-10-25 at 08 34 07
CleanShot 2023-10-25 at 08 33 02
CleanShot 2023-10-25 at 08 48 51

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 402d443 into home-assistant:dev Oct 25, 2023
12 checks passed
@jpbede jpbede deleted the device-info-mac-bluetooth branch October 25, 2023 09:48
@luca-angemi
Copy link
Contributor

hi, should I see the mac address in 2023.11.0b0?
image

@jpbede
Copy link
Member Author

jpbede commented Oct 26, 2023

You need to re-add the device as BTHome lacks those informations. They've been added recently to BTHome and Xiaomi BLE (home-assistant/core#102773)

Besides, please create a issue for something like this, a closed PR isn't the right place to track this :)

@luca-angemi
Copy link
Contributor

My apologies, before opening an issue I wanted to make sure I was doing the right thing.
Thanks, I'll re-add them and test.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants