Change move item todo API #18410
Merged
Change move item todo API #18410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenporter
approved these changes
Oct 25, 2023
| ); | ||
| this._items!.splice(prevIndex + 1, 0, item); | ||
| } | ||
| this._items = [...this._items!]; |
There was a problem hiding this comment.
Is this just making another copy? Seems good just unclear to me as a novice why this is needed.
There was a problem hiding this comment.
It is to force lit to update, otherwise it thinks _items is not changed.
There was a problem hiding this comment.
You can also do this right?
this.requestUpdate("_items");There was a problem hiding this comment.
You can also do this right?
this.requestUpdate("_items");
Not sure if that works with repeat
piitaya
previously approved these changes
Oct 25, 2023
20 tasks
piitaya
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
For home-assistant/core#102795
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: