Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up first load by preloading recorder info #18412

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 25, 2023

Proposed change

Recorder info is always called late when loading the UI which means another round trip to fetch them. Since we know we are going to fetch them anyways, add them as preloads. The recorder prefetch makes a difference outside the local network since the whole UI blocks to wait for it to come back.

follow up to #18384 and #18332

There are still a few other things we fetch nearly every time that are not accounted for but I don't think these are blocking:

  • subscribeLovelaceUpdates
  • title translations
  • subscribeNotifications
  • getEnergyPreferences

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

These are always called late when loading the UI which means another
round trip to fetch them. Since we know we are going to fetch them
anyways, add them as preloads. The recorder prefetch makes quite
a difference outside the local network since the whole UI blocks
to wait for it to come back.

follow up to #18384 and #18332
@bdraco
Copy link
Member Author

bdraco commented Oct 25, 2023

Doesn't look like energy prefs are actually blocking loading so I'll take that back out to make this smaller

@bdraco bdraco changed the title Preload energy prefs and recorder info Preload recorder info Oct 25, 2023
@bdraco bdraco changed the title Preload recorder info Speed up first load by preloading recorder info Oct 25, 2023
@bdraco bdraco marked this pull request as ready for review October 25, 2023 19:20
@bramkragten bramkragten enabled auto-merge (squash) October 25, 2023 19:24
@bramkragten bramkragten merged commit c3743b5 into dev Oct 25, 2023
8 checks passed
@bramkragten bramkragten deleted the first_load_speed_ups branch October 25, 2023 19:29
@bdraco
Copy link
Member Author

bdraco commented Oct 25, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants