Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce slider handle size #18427

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Reduce slider handle size #18427

merged 1 commit into from
Oct 26, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Oct 26, 2023

Proposed change

When migrating to material web component, the slider handle size was increased. This PR is a proposal to reduce the size because the UI can look too cluttered.

Before

CleanShot 2023-10-26 at 11 45 14

After

CleanShot 2023-10-26 at 11 44 52

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes Dot Slider #18417
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2023.11 milestone Oct 26, 2023
@piitaya piitaya requested a review from bramkragten October 26, 2023 09:50
@piitaya piitaya mentioned this pull request Oct 26, 2023
3 tasks
@piitaya
Copy link
Member Author

piitaya commented Oct 26, 2023

Checked with @matthiasdebaat. We will use 14px for the size.

@piitaya piitaya requested a review from frenck October 26, 2023 10:25
@piitaya piitaya merged commit a7dc2cf into dev Oct 26, 2023
14 checks passed
@piitaya piitaya deleted the ha-slider-size branch October 26, 2023 13:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dot Slider
2 participants