Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for lovelace resources not loaded #18430

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Oct 26, 2023

Proposed change

This should fix the issue of lovelace resources not loaded. It's only a quick fix, we have to investigate why hass config can be null for some cases.

I also rollback the change from #18382 in ha-panel-lovelace.ts to avoid blocking other things when loading resources.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2023.11 milestone Oct 26, 2023
@piitaya piitaya enabled auto-merge (squash) October 26, 2023 13:36
@piitaya piitaya disabled auto-merge October 26, 2023 13:37
@piitaya piitaya merged commit d491d8f into dev Oct 26, 2023
10 checks passed
@piitaya piitaya deleted the quick_fix_lovelace_resources branch October 26, 2023 13:37
@SmarterHomeLife
Copy link

Thanks, will this fix be included in 2023.11.0b1?

@piitaya
Copy link
Member Author

piitaya commented Oct 26, 2023

@SmarterHomeLife Yes

@bschatzow
Copy link

I still see this issue in B1 with the Android mobile app. If I refresh the cards come back for under a second and then fail again

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom cards doesn't load on 2023.11.0b0
3 participants