Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization to service call exceptions #18447

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Oct 27, 2023

Proposed change

Add localization to service call exceptions

Needs home-assistant/core#102592

Example of localize custom error message when reloading the MQTT YAML config:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@jbouwh jbouwh added the Backend Change Required Requires a Backend Core Code Change label Oct 27, 2023
src/state/connection-mixin.ts Outdated Show resolved Hide resolved
src/state/connection-mixin.ts Outdated Show resolved Hide resolved
@jbouwh jbouwh marked this pull request as ready for review October 30, 2023 16:16
@bramkragten bramkragten added wait for backend and removed Backend Change Required Requires a Backend Core Code Change labels Nov 1, 2023
@jbouwh jbouwh force-pushed the exception-translations branch from 43c2c5e to 876f3a1 Compare November 1, 2023 17:50
@jbouwh jbouwh requested a review from bramkragten November 2, 2023 22:32
@bramkragten bramkragten merged commit fd9c24d into home-assistant:dev Nov 7, 2023
12 checks passed
@jbouwh jbouwh deleted the exception-translations branch November 28, 2023 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants