Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce circular slider sensitivity when used in card #18908

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 5, 2023

Proposed change

Reduce circular slider sensitivity for thermostat card and humidifier card.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2023.12 milestone Dec 5, 2023
@bramkragten
Copy link
Member

Shouldnt we maybe increase the threshold of the hammer recognizer?

@piitaya
Copy link
Member Author

piitaya commented Dec 5, 2023

I'm not sure because it's a circular slider so all direction are checked...

@piitaya
Copy link
Member Author

piitaya commented Dec 5, 2023

One other thing we can do is to limit the starting zone to the target circle instead of the full slider. But it will change the UX for interaction...

@bramkragten
Copy link
Member

What would be the change in UX in that case?

@piitaya
Copy link
Member Author

piitaya commented Dec 5, 2023

If we make the dot only draggable, it will be different between card and more info (and compared to other slider too)

@bramkragten
Copy link
Member

Oh sorry, I misread, get it now :-)

@bramkragten bramkragten merged commit de83ad7 into dev Dec 5, 2023
12 checks passed
@bramkragten bramkragten deleted the reduce_circular_slider_sensitivity_card branch December 5, 2023 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants