Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce sensitivity of the circular slider on touch devices #18921

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 6, 2023

Proposed change

Adds a 60ms touch press to activate the circular slider on thermostat and humidifier card to prevent activation when scrolling. I tested on desktop (no change) and on iPhone 13 and OnePlus 8. Sensitivity can be adjusted based on users feedbacks.
Interaction margin adjustment is not needed anymore with this change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2023.12 milestone Dec 6, 2023
@piitaya piitaya merged commit b4ab0fc into dev Dec 6, 2023
13 checks passed
@piitaya piitaya deleted the reduce_sensitivity_thermostat_card branch December 6, 2023 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants