Localize date-range-picker #18945
Localize date-range-picker #18945
Conversation
|
@arunshekher - Could use your assistance/opinion for a Malayalam translation issue here, if you wouldn't mind to take a look (see image in top post) |
|
We can just use
|
|
@karwosts Perhaps the agglutinative nature of the language and complex script characters makes the strings longer, but they are already in the shortened form and denotes just the names of the celestial bodies that represents the day without the 'day' part. If you want to shorten it further I think we can make it something like below. But I have never seen such a convention used in print or web.
|
|
I took another look at the calendar CSS and I think I figured out the right way to make it flex correctly, so I think it will be ok for all languages, it will just be a bit wider for some. Thanks for taking the time to check. |
|
Updated:
|
src/common/datetime/localize_date.ts
Outdated
| short: boolean | ||
| ): string => { | ||
| const date = new Date(Date.UTC(1970, 0 + month, 1)); | ||
| return new Intl.DateTimeFormat(language, { |
There was a problem hiding this comment.
Instead of creating 12 instances of DateTimeFormat, can we reuse it?
| timeZone: "UTC", | ||
| }).format(date); | ||
| }; | ||
|
|
||
| export const localizeWeekdays = memoizeOne( |
There was a problem hiding this comment.
Last question, how often do we call this function, is it needed to be memoized?
There was a problem hiding this comment.
I don't pretend to understand the full page load sequence, but just by breakpoints and log messages looks like the Vue date-range-picker createElement function is called 4 times every time we navigate to the energy page (+1 more time when the picker is expanded), and 5 times every time we navigate to the history page (+1 more time when the picker is expanded).
There was a problem hiding this comment.
Also seems to be called 6 more times every time we change an entity in the history panel 😕
There was a problem hiding this comment.
Seems less than ideal, but another issue 👍
Proposed change
Localizing the weekdays in date range picker. I think we still need to do the months as well, but wanted to get a review of this before moving to that.
Looking at what's currently on lokalize, this seems like it would work good for every language except Malayalam, which currently has pretty long strings for abbreviated weeekday, and get some overflow issues.I'm not sure if there's anything I can do there except just push it out and wait for someone to come update it to be shorter?Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: