Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular progress improvement in update area #18983

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Dec 9, 2023

Proposed change

Circular progress was displayed incorrectly on the update page after the upgrade to material design 3 component.

For the update area, the UX has been improved while being there:

  • The circular progress now has an aria-label for accessibility.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Dec 9, 2023
@bramkragten
Copy link
Member

bramkragten commented Dec 12, 2023

Not sure if I'm a fan of moving the circular progress, especially on mobile space is pretty limited, and placing the it above the image seems ok to me...

CleanShot 2023-12-12 at 14 41 52@2x

CleanShot 2023-12-12 at 14 42 44@2x

Also that the spinner is now no longer in the center of the row bothers me 😅

@matthiasdebaat any opinion?

@piitaya
Copy link
Member

piitaya commented Dec 18, 2023

Material web is updated so patch is not needed anymore : #19064

@matthiasdebaat
Copy link
Collaborator

Not sure if I'm a fan of moving the circular progress, especially on mobile space is pretty limited, and placing the it above the image seems ok to me...

Also that the spinner is now no longer in the center of the row bothers me 😅

@matthiasdebaat any opinion?

CleanShot 2023-12-18 at 14 09 58

The current implementation, swapping the chevron with the spinner, is a smart thing to do IMO. Let's keep that.
I would love to keep the dialog and list item animations the same. Can we do something similar as the list item?

@silamon silamon reopened this Dec 22, 2023
@github-actions github-actions bot removed the Dependencies Pull requests that update a dependency file label Dec 22, 2023
@silamon
Copy link
Contributor Author

silamon commented Dec 22, 2023

I've went back to having the circular progress on the state icon. I've considered the design suggestion from Matthias, but the meta icon isn't displayed at all in mobile view and this problem focuses on the smaller view. The line progress can be used but you need to reserve more space and then it's still not clear to what update the line progress belongs. A circular progress isn't clear enough for the when the progress is determinate.

@bramkragten bramkragten merged commit a2ffd0a into home-assistant:dev Dec 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update spinner appears broken in iOS Home Assistant since 2023.12
4 participants