Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

climate: Add preset exemple #19092

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Dec 20, 2023

Proposed change

climate: Add preset exemple

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

- type: thermostat
  entity: climate.overkiz_radiator
  features:
    - type: climate-preset-modes
      style: icons
      preset_modes:
        - none
        - frost_protection
        - eco
        - comfort
        - comfort-1
        - comfort-2
        - auto
        - boost
        - external
        - prog

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Dec 20, 2023
@Quentame Quentame requested a review from piitaya December 20, 2023 02:26
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the contribution.

Only build-in preset are included in the front-end because we do not want a huge preset icon list based on custom presets for every integration. (See build-in presets).

However, we are working on icon translations to allow every integration to provide icon for every attribute. This will fix the issue. It will be available soon.

@Quentame
Copy link
Member Author

Thank for the contribution.
Trying tiny stuff into frontend, coming from core ☺️
Full-stack at my job but usually more on frontend, on HA it's the opposite ... WTF ! 😄

Only build-in preset are included in the front-end because we do not want a huge preset icon list based on custom presets for every integration. (See build-in presets).

Yes of course, that's why I did not add other overkiz presets as I think those might be more common.
I better open a arch discussion to add some build-in preset as frost_protection or auto.

However, we are working on icon translations to allow every integration to provide icon for every attribute. This will fix the issue. It will be available soon.

Niiiice 🎉

@Quentame Quentame changed the title climate: Add none, frost_protection & auto preset mode icons climate: Add preset exemple Dec 20, 2023
@Quentame
Copy link
Member Author

So I reverted icon changes and change PR goal to only add gallery exemple for climate heater presets.

And #19093 is doing the same for climate fan.

@Quentame Quentame force-pushed the climate_add_preset_icons branch from 80eaedd to 7e6addc Compare December 24, 2023 10:52
@bramkragten bramkragten added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Dec 27, 2023
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 26, 2024
@bramkragten bramkragten merged commit 7ca5467 into home-assistant:dev Mar 27, 2024
14 checks passed
@Quentame Quentame deleted the climate_add_preset_icons branch August 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Related to Home Assistant design gallery needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants