Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-player: Show volume slider in more cases #19105

Conversation

NasaGeek
Copy link
Contributor

@NasaGeek NasaGeek commented Dec 21, 2023

Proposed change

Show a disabled volume slider in cases where the device's volume is reported but can't be "set". This is useful for displaying the volume level even if it can't be changed. I'm working on such functionality for the hdmi_cec integration, and it appears to be the case for some other integrations like epson and androidtv_remote.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

hdmi_cec:
  host: <some-address>
  platform: media_player
  devices:
    AVR: 1.0.0.0

Here's my hdmi_cec snippet. Obviously not really applicable to anyone else, but maybe you get the gist?

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Old look:
image

New look:
image

Specifically, we can show a disabled volume slider in cases where the
device's volume is reported but can't be "set". hdmi_cec is an example
of this.
@NasaGeek
Copy link
Contributor Author

The hdmi_cec functionality to enable this for that integration isn't merged yet.

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 20, 2024
@github-actions github-actions bot closed this Mar 27, 2024
@cypherbits
Copy link

Is this gonna be reopen or a new request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants