Add description and due support to todo lists #19107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
reviewed
Dec 21, 2023
Comment on lines
+95
to
+96
| scrimClickAction | ||
| escapeKeyAction |
There was a problem hiding this comment.
Suggested change
| scrimClickAction | |
| escapeKeyAction |
Do you think we can allow escape to easily close the popup if the user misclick the checkbox and it opens the dialog?
There was a problem hiding this comment.
The rule is to not allow it on dialogs with input forms 🤷
Comment on lines
232
to
255
| <span> | ||
| ${this.hass!.localize( | ||
| "ui.panel.lovelace.cards.todo-list.unchecked_items" | ||
| )} | ||
| </span> | ||
| ${this.todoListSupportsFeature(TodoListEntityFeature.MOVE_TODO_ITEM) | ||
| ? html` | ||
| ? html`<ha-button-menu> | ||
| <ha-icon-button | ||
| class="reorderButton" | ||
| .path=${mdiSort} | ||
| .title=${this.hass!.localize( | ||
| slot="trigger" | ||
| .path=${mdiDotsVertical} | ||
| ></ha-icon-button> | ||
| <ha-list-item @click=${this._toggleReorder} graphic="icon"> | ||
| ${this.hass!.localize( | ||
| "ui.panel.lovelace.cards.todo-list.reorder_items" | ||
| )} | ||
| @click=${this._toggleReorder} | ||
| .disabled=${unavailable} | ||
| > | ||
| </ha-icon-button> | ||
| ` | ||
| <ha-svg-icon | ||
| slot="graphic" | ||
| .path=${mdiSort} | ||
| .disabled=${unavailable} | ||
| > | ||
| </ha-svg-icon> | ||
| </ha-list-item> | ||
| </ha-button-menu>` | ||
| : nothing} |
There was a problem hiding this comment.
Should we hide unchecked header if there is no unchecked items?
There was a problem hiding this comment.
not sure we should hide or just show a message underneath that There are no items to do!
piitaya
reviewed
Dec 21, 2023
piitaya
approved these changes
Dec 21, 2023
|
FYI I've got a pending PR to change the API to support clearing fields home-assistant/core#106208 |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: