-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tile pointer/ripple/index when it has no action #19137
Conversation
I would leave "on_hover" effects even for Tiles w/o tap_actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We should use ifDefined
directive to avoid unnecessary attribute in the DOM.
Co-authored-by: Paul Bottein <[email protected]>
* Remove tile pointer/ripple/index when it has no action * update * Apply suggestions from code review Co-authored-by: Paul Bottein <[email protected]> --------- Co-authored-by: Paul Bottein <[email protected]>
Proposed change
If a tile card (or tile card icon) explicitly defines no action, remove the visual suggestions that is interactive:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: