Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only focus search when not in fullscreen dialog #19153

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

bramkragten
Copy link
Member

Proposed change

On mobile it is annoying when the on screen keyboard pops up and changes the layout, so we limit focussing the search bar to none fullscreen dialogs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten enabled auto-merge (squash) December 27, 2023 12:45
@bramkragten bramkragten merged commit 6911685 into dev Dec 27, 2023
10 checks passed
@bramkragten bramkragten deleted the only-focus-search-when-not-in-fullscreen-dialog branch December 27, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants