Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ha-combo-box helper text not displaying text #19154

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Dec 27, 2023

Proposed change

The helper text (data_description) of the integrations strings.yaml from core did not work for selectors using the ha-combo-box, but only displayed [object Object] because the helper property was missing a dot prefix. This PR adds the missing dot.

Before:
image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@jpbede jpbede changed the title Fix ha-combo-box helper text Fix ha-combo-box helper text not displaying text Dec 27, 2023
@bramkragten bramkragten enabled auto-merge (squash) December 27, 2023 15:11
@bramkragten bramkragten merged commit 8bfae3b into home-assistant:dev Dec 27, 2023
9 checks passed
@jpbede jpbede deleted the ha-combo-box-description branch December 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants