Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize time pattern trigger in automation editor #19173

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Dec 28, 2023

Proposed change

Localize time pattern trigger in the automation editor. It's yet another complex translation to add unfortunately because of the very dynamic way the sentence is built together.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@karwosts
Copy link
Contributor

Wow did not think anyone would attempt this one 😅

Very minor nit, but the following pattern:

platform: time_pattern
hours: "0"
seconds: "0"

generates a slightly incorrect string:

Trigger on the 0th second of on the 0th minute of the 0th hour.

It's subtle enough could probably let it go if it's difficult to fix, but just wanted to point that out if you want to look at it. Adding minutes: "0" makes the string correct, so you're probably really close, maybe just a minor correction needed.

@karwosts karwosts added the localization Translations and Localization label Jan 6, 2024
@bramkragten bramkragten merged commit 3b6b77c into home-assistant:dev Jan 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed localization Translations and Localization
Projects
None yet
3 participants