-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clickForMoreInfo to statistics graph card #19178
Add clickForMoreInfo to statistics graph card #19178
Conversation
I think this feature is problematic for mobile users (they can't activate tooltips anymore), and the original feature is undergoing some revision (#19144). Might make sense to wait for that to play out before expanding this wider. |
#19144 nice one 👍 i agree, we should wait for this |
Looks like we've gone ahead with making the more-info popups a mouse feature only, so if you wanted to replicate the same logic from #19606, that could probably go ahead now. |
daab881
to
1460d71
Compare
changes from #19606 adopted |
Hi @karwosts do you see a chance that we could get this in before beta cut? |
I don't really do merging, I let the maintainers handle that. But it looks like the first beta cut for frontend has just gone out 😢 |
This will not be merged before we have consensus about the button logic for mobile, it could be merged if it would use the same logic as the current history graph does. |
it should be the same, as it adopts #19606 |
Co-authored-by: Bram Kragten <[email protected]>
is it to late to get it in current beta? 😀 |
Proposed change
This is adopts #19606 from history charts for statistics chart.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: