Fix iteration index when displaying changed variables #19184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Dec 29, 2023
| @@ -212,7 +212,7 @@ export class HaTracePathDetails extends LitElement { | |||
| <div class="padded-box"> | |||
| ${data.map( | |||
| (trace, idx) => html` | |||
| ${idx > 0 | |||
| ${data.length > 1 | |||
There was a problem hiding this comment.
If data.length === 0 we would never get here right? So this check seems useless?
There was a problem hiding this comment.
Sure, if data.length === 0 we don't get here. But if data.length === 1 we sure do, and that's the case fixed by this PR.
There was a problem hiding this comment.
Nevermind I reviewed way too hurried 😅
bramkragten
approved these changes
Dec 30, 2023
bramkragten
deleted the
automation_trace_fix_variable_iteration_index
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix iteration index when displaying changed variables by checking the number of iterations instead of checking the index of the iteration being formatted
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: