Improve message when an automation step was not executed #19185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Dec 29, 2023
| "no_further_execution": "This node was not executed and so no further trace information is available.", | ||
| "disabled_node": "This node was disabled and skipped during execution so no further trace information is available.", | ||
| "no_further_execution": "This step was not executed and so no further trace information is available.", | ||
| "disabled_step": "This step was disabled and skipped during execution so no further trace information is available.", |
There was a problem hiding this comment.
Can we keep the same keys, so the translations are not lost?
There was a problem hiding this comment.
Yes, but translations were added only 2 weeks ago and are not in a release yet, do we need to keep the keys? 🤔
There was a problem hiding this comment.
They are probably already translates though, let me check
There was a problem hiding this comment.
When you change the key of a translation, the old and new key of the translation are kept in localise. So, if it is already translated, the translation has to be redone. If it isn't, the translation needs to be translated twice. Next time, keep the key, then the translation is kept for history and doesn't need to be translated once or twice.
9 tasks
bramkragten
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve message when an automation step was not executed
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: