Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message when an automation step was not executed #19185

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Improve message when an automation step was not executed #19185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c342bf
Improve message when an automation step was not executed
emontnemery Dec 29, 2023
9512ddc
Use step instead of node
emontnemery Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/trace/ha-trace-path-details.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export class HaTracePathDetails extends LitElement {

if (result?.enabled === false) {
return html`${this.hass!.localize(
"ui.panel.config.automation.trace.path.disabled_node"
"ui.panel.config.automation.trace.path.disabled_step"
)}`;
}

Expand Down Expand Up @@ -240,7 +240,7 @@ export class HaTracePathDetails extends LitElement {
if (index === -1) {
return html`<div class="padded-box">
${this.hass!.localize(
"ui.panel.config.automation.trace.path.node_not_tracked"
"ui.panel.config.automation.trace.path.step_not_executed"
)}
</div>`;
}
Expand Down
8 changes: 4 additions & 4 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2988,15 +2988,15 @@
"blueprint_config": "Blueprint Config"
},
"path": {
"choose": "Select a node on the left for more information.",
"choose": "Select a step on the left for more information.",
"default_action_executed": "The default action was executed because no options matched.",
"no_further_execution": "This node was not executed and so no further trace information is available.",
"disabled_node": "This node was disabled and skipped during execution so no further trace information is available.",
"no_further_execution": "This step was not executed and so no further trace information is available.",
"disabled_step": "This step was disabled and skipped during execution so no further trace information is available.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the same keys, so the translations are not lost?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but translations were added only 2 weeks ago and are not in a release yet, do we need to keep the keys? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are probably already translates though, let me check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you change the key of a translation, the old and new key of the translation are kept in localise. So, if it is already translated, the translation has to be redone. If it isn't, the translation needs to be translated twice. Next time, keep the key, then the translation is kept for history and doesn't need to be translated once or twice.

"iteration": "Iteration {number}",
"executed": "Executed: {time}",
"error": "Error: {error}",
"result": "Result:",
"node_not_tracked": "Node not tracked.",
"step_not_executed": "This step was not executed.",
"no_logbook_entries": "No Logbook entries found for this step.",
"no_variables_changed": "No variables changed",
"unable_to_find_config": "Unable to find config"
Expand Down
Loading