Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media browser: reverse sort & filter #19199

Closed
wants to merge 4 commits into from

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Dec 30, 2023

Proposed change

Add a filter box for media browser, and a button to reverse the sort order.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

While I really understand the filter function, and it is great for, for example, the radio browser, I think we need a search function more. Like being able to search through all of Spotify etc. This would be a feature that should be provided by the integration.

I feel like if we add filter now, it will bite us in the ass if we add a search feature later, as they would share a similar UI.

@karwosts
Copy link
Contributor Author

karwosts commented Jan 10, 2024

I feel like if we add filter now, it will bite us in the ass if we add a search feature later, as they would share a similar UI.

I guess I would think if an integration provided a search, it could just drop in as an exact replacement for the current UI? (The serach-bar can filter if there is no search support, or perform deep search if there is search support). So I don't feel like this would necessarily be a step in the wrong direction? (And I have no idea if true search will ever come, or how many years away that could be)

But if you don't feel like this is workable in any form, feel free to close the PR. Thanks!

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@karwosts
Copy link
Contributor Author

Closing, not accepted.

@karwosts karwosts closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants