Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing device classes for entity-registry-settings-editor #19231

Conversation

joshmcrty
Copy link
Contributor

Proposed change

Currently the "Show as" dropdown for binary sensors does not have "Connectivity" or "Update" as an option. I noticed this when I created a group binary sensor for multiple ping sensors. This PR adds the connectivity and update device classes to the dropdown. Both of these binary_sensor device classes are listed in the /src/common/entity/get_states.ts and translations files, but were missing from the dropdown.

After change:
Screenshot 2024-01-02 at 10 06 39 AM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Edit the settings of any binary sensor, in the Show as dropdown there is no option for Connectivity or Update before this PR. After this PR those options are available.

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 2024.1 milestone Jan 2, 2024
@bramkragten bramkragten enabled auto-merge (squash) January 2, 2024 17:30
@bramkragten bramkragten merged commit def2ead into home-assistant:dev Jan 2, 2024
9 checks passed
bramkragten pushed a commit that referenced this pull request Jan 2, 2024
* Add connectivity device class for binary sensors

* Add update device class

* Separate connectivity and update
@joshmcrty joshmcrty deleted the add-missing-device-class-entity-settings branch January 2, 2024 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants