Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default values for required and disabled for labeled slider #19246

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Jan 2, 2024

Proposed change

A material web package regression causes the slider to be disabled if disabled is set to undefined. Unfortunately, that's the case for the components that use ha-labeled-slider. This sets a default value.

(If possible, please tag for beta release)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon changed the title Set default values for labeled slider Set default values for required and disabled for labeled slider Jan 2, 2024
@bramkragten bramkragten added this to the 2024.1 milestone Jan 2, 2024
@bramkragten bramkragten merged commit 8a8b04e into home-assistant:dev Jan 2, 2024
10 checks passed
bramkragten pushed a commit that referenced this pull request Jan 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGBW light sliders disabled
2 participants