-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple automation trigger for Timer events #19252
base: dev
Are you sure you want to change the base?
Conversation
This is great and exactly what I am working on making a plan for right now! More specific triggers. |
I think it might make sense to make the Event multi selectable, i.e. checkboxes. I can think of several occasions where I'd want to trigger an automation for different timer events, and having to "multiply" the trigger definition wouldn't make sense. Don't know how this relates to bramkragten's comment, though... |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
I haven't seen many changes yet in that area so I assume that plan isn't finished as of now? |
We are currently in the design process of the automation editor, it is a long process though, I'll discuss with product if we should hold this that long. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
keep alive |
Proposed change
I like using timer helpers for automations, but I think the experience leaves something to be desired. Even as an experienced user I still have to go review the documentation every time I want to use one, to remember how to structure the necessary manual events. I think this could be somewhat difficult for new users as well, given that the manual event trigger describes itself as an "advanced concept".
As an alternative, I propose a simpler UI "Timer trigger", which just has an entity id picker, and a select to choose a timer event to listen for. I believe this would be much more accessible than having to setup a manual event trigger.
I debated if this would need to be a "real" trigger in the backend, or if we could just wrap the existing event with a new UI, and not really need any core changes. I decided to try the latter for now, as the former sounded somewhat more difficult, and possibly unnecessary.
This change does require a one line change in core to allow the validator to accept and ignore the
metadata
field for triggers, similar to how we have done in other areas. I can try an additional PR for that if we think this approach is favorable.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: