Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert conditional rendering of condition #19257

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

Reverts hiding the triggered by condition on the root level

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 2024.1 milestone Jan 3, 2024
frenck
frenck previously approved these changes Jan 3, 2024
frenck
frenck previously approved these changes Jan 3, 2024
piitaya
piitaya previously approved these changes Jan 3, 2024
@bramkragten bramkragten dismissed stale reviews from piitaya and frenck via bd3b785 January 3, 2024 11:08
@bramkragten bramkragten enabled auto-merge (squash) January 3, 2024 11:16
@bramkragten bramkragten merged commit 29fefa1 into dev Jan 3, 2024
9 checks passed
@bramkragten bramkragten deleted the fix-condition-conditions branch January 3, 2024 11:20
bramkragten added a commit that referenced this pull request Jan 3, 2024
* Fix conditionally showing `triggered by`

* revert conditional rendering

* Update add-automation-element-dialog.ts

* Update add-automation-element-dialog.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants