Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select view dialog #19267

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jan 3, 2024

Proposed change

The select view dialog would crash when picking either a strategy generated dashboard, or an empty dashboard with no views.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 2024.1 milestone Jan 3, 2024
@bramkragten bramkragten merged commit 3984702 into home-assistant:dev Jan 3, 2024
13 checks passed
@karwosts karwosts deleted the fix-select-view branch January 3, 2024 19:39
bramkragten pushed a commit that referenced this pull request Jan 4, 2024
* Fix select view dialog

* add import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device "Add to Dashboard" button non
2 participants