Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thermostat and humidifier card rendering when off #19281

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 4, 2024

Proposed change

This PR fixes 2 issues with thermostat card and humidifier card.

Always display temperature (current or target), even if the state if off.

CleanShot 2024-01-04 at 15 04 11

If no temperature is available, display the state at the center instead of label to have bigger text.

CleanShot 2024-01-04 at 15 07 02

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya marked this pull request as ready for review January 4, 2024 14:11
@piitaya piitaya force-pushed the fix_thermostat_card_current_temperature_off branch from 049032b to 701e9f4 Compare January 4, 2024 14:14
@piitaya piitaya added this to the 2024.1 milestone Jan 4, 2024
@piitaya piitaya merged commit 72dedc7 into dev Jan 4, 2024
13 checks passed
@piitaya piitaya deleted the fix_thermostat_card_current_temperature_off branch January 4, 2024 15:18
bramkragten pushed a commit that referenced this pull request Jan 4, 2024
* Fix thermostat and humidifier card rendering when off

* Fix action color
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants