Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fully closed or fully open check #19285

Closed
wants to merge 1 commit into from

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 4, 2024

Proposed change

Check != null instead of undefined and null.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@steverep steverep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If current_position can be null for either of these, then the types are incorrect and should be adjusted as well.

@home-assistant home-assistant bot marked this pull request as draft January 5, 2024 06:04
@home-assistant
Copy link

home-assistant bot commented Jan 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@piitaya
Copy link
Member Author

piitaya commented Jan 5, 2024

If current_position can be null for either of these, then the types are incorrect and should be adjusted as well.

Oh right! I was following #19278. I agree, we should fix the issue in core to not return null. And if we figure out it's not a core issue, we must adapt the typings!

I will close this PR for now.

@piitaya piitaya closed this Jan 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants