-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible for themes to blur backgrounds #20447
Conversation
This would be a great addition and definitely worth it regarding the small change set! |
Co-authored-by: Bram Kragten <[email protected]>
Should I update this to have the frontend/src/components/ha-dialog.ts Lines 78 to 79 in dd082c2
That would be a breaking change though. |
I think that one is a bit confusing now anyway, as we have multiple variables for the dialog now. Should be We can make the change non breaking though: |
Good point. Should it actually be this?
|
With backwards compatibility
The default is none anyway, so not really needed but sure 👍 |
@@ -119,6 +125,8 @@ export class HaDialog extends DialogBase { | |||
margin-top: var(--dialog-surface-margin-top); | |||
min-height: var(--mdc-dialog-min-height, auto); | |||
border-radius: var(--ha-dialog-border-radius, 28px); | |||
-webkit--filter: var(--ha-dialog-surface--filter, none); | |||
-filter: var(--ha-dialog-surface--filter, none); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a single dash here: --ha-dialog-surface--filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I fixed this in my fork but for some reason not on this branch.
Proposed change
Currently themes have little control over the
backdrop-filter
properties. The only one they can control is the whole screen when a dialog is open:frontend/src/components/ha-dialog.ts
Lines 78 to 79 in dd082c2
This PR makes it possible for themes to control the
backdrop-filter
for cards and dialogs. This allows the use of blurred background among others. For example without and with a blur filter:Type of change
Example configuration
Additional information
Request - Vision OS Theme basnijholt/lovelace-ios-themes#61
Make transparency of cards blurry basnijholt/lovelace-ios-themes#49
check out kibibit/kb-frosted-cards basnijholt/lovelace-ios-themes#22
Checklist
If user exposed functionality or configuration variables are added/changed: