Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock features for tile card #20539

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

marcgeurts
Copy link
Contributor

@marcgeurts marcgeurts commented Apr 17, 2024

Proposed change

Added lock features for the tile card.

Screenshot 2024-04-17 at 14 28 34

Screenshot 2024-04-17 at 14 28 08

image

Screenshot 2024-04-17 at 14 25 39

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: tile
entity: lock.front_door
features:
  - type: lock-commands
  - type: lock-open-door

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Apr 17, 2024
@silamon
Copy link
Contributor

silamon commented Apr 17, 2024

For clearness: This is a continuation of #19880 with the UX feedback applied in #19880 (comment).

@bramkragten bramkragten requested a review from piitaya April 22, 2024 07:41
@piitaya
Copy link
Member

piitaya commented Apr 22, 2024

Thank you for the contribution @marcgeurts!
Can be have the success message as a label instead of a button to keep consistency with the lock more info?
CleanShot 2024-04-22 at 11 19 15

@marcgeurts
Copy link
Contributor Author

marcgeurts commented Apr 23, 2024

Thank you for your review @piitaya, I did consider this before, but wasn't sure because labels weren't used yet with tile cards.

image

I changed it to a label now.

@bramkragten bramkragten merged commit d9b71e7 into home-assistant:dev Apr 24, 2024
13 checks passed
@marcgeurts marcgeurts deleted the lock-tile-card-features branch April 24, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Related to Home Assistant design gallery Tile card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants