Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stopped_unknown_reason localization message #20557

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

karwosts
Copy link
Contributor

Proposed change

Fix error: Translation Error: The intl string context variable "reason" was not provided to the string "Stopped because of unknown reason {reason} at {time} (runtime: {executiontime} seconds)"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@karwosts karwosts requested a review from silamon April 19, 2024 20:38
@karwosts
Copy link
Contributor Author

karwosts commented Apr 19, 2024

@silamon I think you added this string, is it correct that there is no {reason} placeholder?

Is the best fix to push this to translation and then let each language remove it independently from lokalize? All the non-english translations have this placeholder which I believe needs to be removed as well.

@silamon
Copy link
Contributor

silamon commented Apr 19, 2024

Yeah I added it in #19836 but forgot to provide the placeholder after splitting the message. There is a reason that can be provided: this.trace.script_execution

@karwosts
Copy link
Contributor Author

Got it thanks, added the reason.

@silamon silamon merged commit 3a5f4d3 into home-assistant:dev Apr 20, 2024
13 checks passed
@karwosts karwosts deleted the fix_stopped_unknown_reason branch April 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants