-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add css var for meta theme-color attribute #20558
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
It's the same color for the title bar and the "HA bar", as expected. That behavior is unchanged. Only the dark theme behavior is "broken" now. Also seen when just opening the mobile page on iOS with a dark theme -- the status bar becomes light blue (instead of having the same color as the HA bar like before). |
Should be fixed : #20671 |
Proposed change
Previously, it wasn't possible to specifically change the color of the "theme-color" meta tag, which is used on some browsers to color the top bar, or on mobile devices.
The only way was to modify
app-header-background-color
, which also modified the bar at the top of the page, rendering an ugly result.In addition, the tag was correctly updated in light mode, but in dark mode it reverted to blue, regardless of the
primary-color
, which was also ugly.I added
app-theme-color
to specifically modify this tag, and it inheritsprimary-color
by default to keep the same behavior as before, fixing forced blue in dark mode.Before, with red primary color :
After:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: