Fix double unsubscribe in todo list card

[karwosts]

Proposed change

Todo list card is throwing a "subscription not found" error into the logs anytime you navigate to a view with a todo list card. This is because it's calling the unsubscribe function twice, once on disconnect, and once on reconnect (which throws the error).

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• Bug Fixes
  • Improved memory management in the To-Do List card to prevent potential memory leaks.

[coderabbitai]

Walkthrough

Walkthrough

The recent update to the HuiTodoListCard class in the Lovelace UI involves a minor but crucial enhancement to the disconnectedCallback method. This change ensures that _unsubItems is set to undefined during the component's disconnection phase, which helps in preventing potential memory leaks by ensuring proper cleanup of resources.

Changes

File Path	Change Summary
src/panels/lovelace/cards/hui-todo-list-card.ts	Updated disconnectedCallback method to include this._unsubItems = undefined; for proper cleanup

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant HuiTodoListCard
    participant MemoryManager

    User ->> HuiTodoListCard: Disconnect component
    HuiTodoListCard ->> HuiTodoListCard: Call disconnectedCallback()
    HuiTodoListCard ->> MemoryManager: Set _unsubItems to undefined
    MemoryManager -->> HuiTodoListCard: Confirm cleanup
    HuiTodoListCard -->> User: Component disconnected

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 6f1fa13 and f33d7f6.

Files selected for processing (1)

• src/panels/lovelace/cards/hui-todo-list-card.ts (1 hunks)

Additional context used

Biome

src/panels/lovelace/cards/hui-todo-list-card.ts

[error] 145-145: Unexpected any. Specify a different type.

---

[error] 209-209: Forbidden non-null assertion.

---

[error] 218-218: Forbidden non-null assertion.

---

[error] 239-239: Forbidden non-null assertion.

---

[error] 255-255: Forbidden non-null assertion.

---

[error] 283-283: Forbidden non-null assertion.

---

[error] 300-300: Forbidden non-null assertion.

---

[error] 345-345: Forbidden non-null assertion.

---

[error] 378-378: Forbidden non-null assertion.

---

[error] 392-392: Forbidden non-null assertion.

---

[error] 403-403: Forbidden non-null assertion.

---

[error] 422-422: Forbidden non-null assertion.

---

[error] 422-422: Forbidden non-null assertion.

---

[error] 437-437: Forbidden non-null assertion.

---

[error] 473-473: Forbidden non-null assertion.

---

[error] 482-482: Forbidden non-null assertion.

---

[error] 489-489: Forbidden non-null assertion.

---

[error] 489-489: Forbidden non-null assertion.

---

[error] 522-522: Forbidden non-null assertion.

---

[error] 522-522: Forbidden non-null assertion.

Additional comments not posted (1)

src/panels/lovelace/cards/hui-todo-list-card.ts (1)

107-107: The change to set _unsubItems to undefined is a good practice to prevent memory leaks and ensure that the unsubscribe function is not called multiple times.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range comments (2)

src/panels/lovelace/cards/hui-todo-list-card.ts (2)

Line range hint 209-209: Consider avoiding non-null assertions. They bypass TypeScript's strict null checks and can lead to runtime errors if the objects are actually null.

Also applies to: 218-218, 239-239, 255-255, 283-283, 300-300, 345-345, 378-378, 392-392, 403-403, 422-422, 437-437, 473-473, 482-482, 489-489, 522-522

---

Line range hint 145-145: Avoid using the any type to maintain type safety. Consider specifying a more precise type.