Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some polymer paper-tabs to mwc-tabs #21390

Merged
merged 8 commits into from
Jul 31, 2024

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Jul 14, 2024

Proposed change

Change some usages of paper-tabs to mwc-tab-bar. We're currently using a mix of paper-tabs and mwc-tabs. To move away from polymer, we need to replace the paper-tabs eventually by mwc-tabs or md-tabs. Since the last one is unused, and ha-tabs still relies on paper-tab as well, I'm moving these occurrences to mwc-tabs for now.

I've already did many attempts to add support for arrows to the tabs, but it may be too hard to get this working. Moving these occurrences to mwc-tabs takes away the arrows on smaller devices.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@coderabbitai ignore

@silamon silamon marked this pull request as ready for review July 15, 2024 07:29
@bramkragten
Copy link
Member

bramkragten commented Jul 15, 2024

The reason we are still using paper tabs on some places is mainly because it supports dragging it with the mouse, mwc-tabs do not support this. This was a blocker for atleast dev tools and dashboards.

@silamon
Copy link
Contributor Author

silamon commented Jul 17, 2024

I've got the mouse dragging to work with the new material m3 tabs, so I will pull off the dev tools from this one.

@silamon silamon marked this pull request as draft July 19, 2024 08:00
@silamon silamon marked this pull request as ready for review July 24, 2024 17:07
@bramkragten bramkragten merged commit cd4af67 into home-assistant:dev Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants