Don't eat spaces while searching

[silamon]

Proposed change

Alternative fix for #20825 to fix #21325. This doesn't modify the search value in the search field anymore, but trims spaces in front or back of the value when search is being executed.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Keyboard input in search bar eats spaces #21325
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• New Features

  • Improved data filtering for the data table component by enhancing input handling.
  • Adjusted search input processing to allow for untrimmed values, potentially affecting search behavior.

• Bug Fixes

  • Adjusted filtering logic to ensure whitespace does not interfere with data display accuracy.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes focus on the filtering functionality within the data table and search input components. Specifically, the handling of whitespace in user input has been modified. In the HaDataTable, leading and trailing whitespace is now trimmed before filtering, enhancing accuracy. Conversely, in the SearchInputOutlined and SearchInput components, the removal of the trim() method allows unmodified input, which could lead to unintended behavior, particularly with respect to leading spaces.

Changes

Files	Change Summary
src/components/data-table/ha-data-table.ts	Modified _filter parameter in _memFilterData to trim whitespace, improving filtering accuracy.
src/components/search-input-outlined.ts	Altered _filterInputChanged to directly pass untrimmed input value to _filterChanged, which may affect input processing.
src/components/search-input.ts	Changed _filterInputChanged to pass raw input value to _filterChanged, allowing for untrimmed input.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SearchInput
    participant FilterLogic

    User->>SearchInput: Enter "Guest room ac "
    SearchInput->>FilterLogic: Pass "Guest room ac " (untrimmed)
    FilterLogic-->>User: Display filtered results

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Keyboard input in search bar eats spaces (#21325)	✅
	❌	Changes allow untrimmed input, potentially worsening the original issue.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.