Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translationMetadata.json - Added Irish language code #21898

Merged
merged 14 commits into from
Sep 27, 2024

Conversation

aindriu80
Copy link
Contributor

@aindriu80 aindriu80 commented Sep 5, 2024

Proposed change

Add Irish language support to Home Assistant.

As per https://developers.home-assistant.io/docs/translations/#maintainer-steps-to-add-a-new-language instructions I have completed the first two steps:

  1. Retrieve Irish/Gaeilge language code from IANA subtag registry https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
  2. Add 'ga' language code to src/translations/translationMetadata.json

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This pull request is in relation to #21807

Details about the language:-

English Name: Irish
Native Name: Gaeilge
Type: language
Subtag: ga
Description: Irish
Added: 2005-10-16
Suppress-Script: Latn

My Lokalise account: [email protected]

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Summary by CodeRabbit

  • New Features
    • Added support for the Irish language (Gaeilge) to enhance localization and accessibility for Irish-speaking users.

Added language code for Irish, native name Gaeilge
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aindriu80

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft September 5, 2024 15:15
@home-assistant
Copy link

home-assistant bot commented Sep 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@aindriu80 aindriu80 marked this pull request as ready for review September 5, 2024 15:30
Copy link
Contributor

coderabbitai bot commented Sep 5, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The change introduces a new language entry for "Gaeilge" (Irish) in the translationMetadata.json file. This addition expands localization support by including the native name for the Irish language, enhancing the range of languages available in the application. The overall structure of the JSON file remains unchanged, with the new entry integrated alongside existing language entries.

Changes

File Change Summary
src/translations/translationMetadata.json Added new entry for the Irish language: "ga": { "nativeName": "Gaeilge" }

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bramkragten
Copy link
Member

What is your email on Localise, so I can give you access to translate the newly added language?

@aindriu80
Copy link
Contributor Author

What is your email on Localise, so I can give you access to translate the newly added language?

My lokalise email is [email protected]

Thanks!

@aindriu80
Copy link
Contributor Author

What is your email on Localise, so I can give you access to translate the newly added language?

Do you think everything here is ok for a merge? I don't know if I am missing something

@bramkragten
Copy link
Member

What is your email on Localise, so I can give you access to translate the newly added language?

Do you think everything here is ok for a merge? I don't know if I am missing something

Yes, I just need to add it to Lokalise still

@silamon
Copy link
Contributor

silamon commented Sep 24, 2024

It also needs a core PR right similar to this one: home-assistant/core#122768?

@bramkragten
Copy link
Member

It also needs a core PR right similar to this one: home-assistant/core#122768?

Oh right yeah, true, we should update the docs

@aindriu80
Copy link
Contributor Author

It also needs a core PR right similar to this one: home-assistant/core#122768?

Oh right yeah, true, we should update the docs

I went ahead and created a PR home-assistant/core#126689

@silamon
Copy link
Contributor

silamon commented Sep 27, 2024

No need to keep the pull requests updated with the latest dev. It will be merged quite soon, when people from Home Assistant are able to set up the things in Lokalise.

@aindriu80
Copy link
Contributor Author

No need to keep the pull requests updated with the latest dev. It will be merged quite soon, when people from Home Assistant are able to set up the things in Lokalise.

Oh I see, thank you very much ! it was a bit confusing >< !

@bramkragten bramkragten merged commit 8223f6b into home-assistant:dev Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants