-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translationMetadata.json - Added Irish language code #21898
Conversation
Added language code for Irish, native name Gaeilge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aindriu80
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe change introduces a new language entry for "Gaeilge" (Irish) in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
What is your email on Localise, so I can give you access to translate the newly added language? |
My lokalise email is [email protected] Thanks! |
Do you think everything here is ok for a merge? I don't know if I am missing something |
Yes, I just need to add it to Lokalise still |
It also needs a core PR right similar to this one: home-assistant/core#122768? |
Oh right yeah, true, we should update the docs |
I went ahead and created a PR home-assistant/core#126689 |
No need to keep the pull requests updated with the latest dev. It will be merged quite soon, when people from Home Assistant are able to set up the things in Lokalise. |
Oh I see, thank you very much ! it was a bit confusing >< ! |
Proposed change
Add Irish language support to Home Assistant.
As per https://developers.home-assistant.io/docs/translations/#maintainer-steps-to-add-a-new-language instructions I have completed the first two steps:
Type of change
Additional information
This pull request is in relation to #21807
Details about the language:-
English Name: Irish
Native Name: Gaeilge
Type: language
Subtag: ga
Description: Irish
Added: 2005-10-16
Suppress-Script: Latn
My Lokalise account: [email protected]
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit