Allow entities table to delete helpers

[karwosts]

Proposed change

If you click on a helper more-info, you are allowed to delete it.

If you select a helper in entities table (w/ multi-selection) and try to delete, the popup tells you it can't be deleted.

This change allows the entities table delete flow to also delete helpers, so it is more consistent (and much easier to clean up large groups of unwanted helpers)

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[bramkragten]

Not all helpers are config entries, the old style helpers are collection type helpers, like the input helpers. These are not handled in this PR.

[bramkragten]

Would it maybe make more sense to start adding this to the helper config page (multi delete)?

[karwosts]

These are not handled in this PR.

Are you certain I didn't handle them? I thought I duplicated the same logic that more-info uses to determine deletability.

e.g.:

          if (configEntryId) {
            deleteConfigEntry(this.hass, configEntryId);
          } else {
            removeEntityRegistryEntry(this.hass, entity);
          }

[karwosts]

Would it maybe make more sense to start adding this to the helper config page (multi delete)?

I'd probably be up for that at some point, but I've already got another PR open for helper config with quite a few changes already.

I do think it makes sense to add here though as well, if it's technically feasible.

[bramkragten]

These are not handled in this PR.

Are you certain I didn't handle them? I thought I duplicated the same logic that more-info uses to determine deletability.

e.g.:

          if (configEntryId) {
            deleteConfigEntry(this.hass, configEntryId);
          } else {
            removeEntityRegistryEntry(this.hass, entity);
          }

You would need:

        await HELPERS_CRUD[this.entry.platform].delete(
          this.hass,
          this._item.id
        );

These helpers actually have their own more info settings element entity-settings-helper-tab

[karwosts]

Calling removeEntityRegistryEntry on helpers like input_boolean still seems to work correctly at first glance (removes the entity from the table and I don't find any further vestiges of it).

I wonder what the difference is with the other API method.

But I'll attempt to add the code from that helper-tab file as well.

[karwosts]

So I did another pass through and I think I've covered all the cases, but this ended up being way more complicated than I originally anticipated 😅 . I imagine it's quite hard to review but since I went through the trouble I'll put it out there.

[silamon]

I still have around 600 helpers that existed to test performance issues some months ago. The yaml configuration has already been remove, but they still remain in the entity table, marked as no longer existing with a red exclamation mark at the end.

These were setup through yaml like this:

counter:
  my_custom_counter:
    initial: 30
    step: 1

At current stable (not this branch), they can be deleted at this time with multi selection.
Sending {type: 'config/entity_registry/remove', entity_id: 'counter.my_custom_counter'}

On this branch, it appears to call right now with multi selection:
Sending {type: 'counter/delete', counter_id: 'my_custom_counter'}
But since the entity no longer exists it fails with
Error {code: 'not_found', message: 'Unable to find counter_id my_custom_counter'}

[karwosts]

Thanks for checking, I believe I have fixed that case. 👍

[silamon]

Thanks for checking, I believe I have fixed that case. 👍

Yeah you did. 🥇