Move date-range-picker to Top for Logbook and History

[boern99]

Breaking change

Proposed change

This is an missing Style-Improvement for bed470f
@wendevlin: referring your discussion: #22802 (comment)

Displays Prev. and Next buttons also on mobiles.
Similar to the Energy Dashboard, selecting the date in the header area offers added value, especially on mobile devices.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[wendevlin]

@boern99 can you add a mobile screenshot too please?

[boern99]

@boern99 can you add a mobile screenshot too please?

[bramkragten]

Why not use a shorter format for the date like we do on the energy dashboard?

[bramkragten]

In your mobile screenshot I miss the button to select a date?

[boern99]

In your mobile screenshot I miss the button to select a date?

can be selected by clicking on the date

[boern99]

Why not use a shorter format for the date like we do on the energy dashboard?

used the date format from the actual code, including the time. In Energy Dashboard there is no time.

[boern99]

should i use a shorter Date Format? But when i leave the time Information: it would need more space than in Energy Dashboard: 2 Lines for start and end date as in this PR? Leave the Dateselector until there is no space left? Would it be better to hide the Date and leave the Dateselector? If you like to change the code feel free to make a Suggestion.

[wendevlin]

It's a good idea, but we have to discuss this with the UX team.
I don't like that the time is seperated from the target picker, moreover you don't see that it is about from - to timerange.

I am pretty sure we can get an awesome design to improve this selector, it is possible that it can take some time.

[marcinbauer85]

@boern99 We've prepared a design that should solve some of the UI/UX problems.
https://www.figma.com/design/bTQGfCdVnqUYSi7aIJTWkX/HA-20?node-id=2-110&node-type=section&t=QhqWFLDwHzAMsVa3-11

[boern99]

@boern99 We've prepared a design that should solve some of the UI/UX problems. https://www.figma.com/design/bTQGfCdVnqUYSi7aIJTWkX/HA-20?node-id=2-110&node-type=section&t=QhqWFLDwHzAMsVa3-11

Yes this would be better than now but in my opinion not as good as my last version in this pull request. Why has the Energy-Dashboard its Date-Selector in the Header and Loogbook and History should not? That doesn't really look right to me. The header would also have the advantage that it sticks at the top what specially for mobiles would have an advantage.

[wendevlin]

The difference to energy dashboards are:

• it is just a day picker
• there are no other inputs

We would like to have all inputs together time range + target picker, that won't be possible in the top bar.

[boern99]

The difference to energy dashboards are:

• it is just a day picker
• there are no other inputs

We would like to have all inputs together time range + target picker, that won't be possible in the top bar.

and what about the "Remove all selections" button?

[wendevlin]

😄 good catch. Yeah I would say it is not right placed.

I understand that you invested time in implementing your solution and thats awesome thank you!

We discussed it and ask for design help from @marcinbauer85. We know that not all parts are consistent and that there are multiple oppinions on how to design panels. We have one more designer and try our best to work on a consistent design everywhere.

If you don't have enough time to change it to Marcins version, I can try to implement it next week.

[boern99]

Tried it and made a draft, but have not uploaded it now as i made some other changes and i am not sure if i should upload it to this pull request, and for the new features, if i should split them into seperate Pull-Requests.
For the suggested Layout-Change: I am struggling a bit as the ha-textfield uses an input-element.

If we need to have 2 Lines for mobiles: ha-textfield and its input-element is then not suitable.
I am also testing 2 new functions for zoom-in and zoom-out: We should take into account that we probably need more space for them if they should find its way into a future release?

And another change would be an improved logic for recognizing whole month, so that the Previous and Next-Buttons can replace
"Next Month" and "Next Year". Removing the Previous-Buttons would fit better on mobile-Devices, as now the space on mobiles for the datepicker is borderline. I would suggest to remove them:

[marcinbauer85]

@boern99 the energy dashboard has a old design implemented, which doesn't account for corner cases like for history and logbook. The top bar is overcrowded especially on mobile, and based even on old MD2 design principles it shouldn't be used for picking dates and filtering (top bars are mostly for navigation and general view options), hence the UI proposed in the design is in the content area, which will lay a foundation for future UX improvements to this and other views.

@wendevlin might help with the input situation.

As for zoom in/out, these are controls that are related to the graph itself, so having them near the date picker might be confusing. Also graphs could benefit of pinch/pan/zoom gestures on mobile, rather than specific buttons.
I know @MindFreeze discussed a possible solution for making graphs more accessible, maybe you could chime in?

[MindFreeze]

UX is still subject to change but I am working on zoom for graphs #23183

[wendevlin]

@boern99 there is ha-textarea maybe you can use this on mobile for multiline?