Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle switch for exposing of new entities to Assist #23127

Merged

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Dec 3, 2024

Proposed change

Added a toggle switch to disable the exposure of new entities for Assist. As far as I saw core already supports this, but there was no possibility in the frontend so far.

WTH: https://community.home-assistant.io/t/wth-are-all-new-entities-exposed-to-assist-by-default/803889
This seems to be a feature request as well: https://community.home-assistant.io/t/assist-dont-expose-newly-added-entities-automatically-to-it/598434

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@home-assistant home-assistant bot added cla-signed WTH Issues & PRs generated from the "Month of What the Heck?" labels Dec 3, 2024
@wendevlin wendevlin added the Needs UX Pull requests requiring a review from the Home Assistant design team label Dec 4, 2024
@jpbede jpbede force-pushed the assist-expose-new-entities-toggle branch from bcabdf3 to 1e1c122 Compare December 9, 2024 08:50
@jpbede jpbede marked this pull request as draft December 9, 2024 12:12
@jpbede jpbede force-pushed the assist-expose-new-entities-toggle branch from a3dd8b8 to d4cb58f Compare December 9, 2024 12:12
@jpbede jpbede marked this pull request as ready for review December 9, 2024 12:17
@bramkragten
Copy link
Member

Can we move the toggle row to below the assistants? Also can we make sure the toggle row text aligns with the assistant rows 😄

@jpbede
Copy link
Member Author

jpbede commented Dec 12, 2024

Also can we make sure the toggle row text aligns with the assistant rows 😄

Dang it, why didn't I notice this before? 🙈
Should we align the assist rows with the rest?

image

@bramkragten
Copy link
Member

Yeah, I think that is wise, the row was just copied from the alexa and google one right?

@jpbede
Copy link
Member Author

jpbede commented Dec 22, 2024

Right

@bramkragten bramkragten enabled auto-merge (squash) December 22, 2024 16:02
@bramkragten bramkragten merged commit 14bebc7 into home-assistant:dev Dec 22, 2024
11 checks passed
@jpbede jpbede deleted the assist-expose-new-entities-toggle branch December 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Needs UX Pull requests requiring a review from the Home Assistant design team WTH Issues & PRs generated from the "Month of What the Heck?"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants