-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MFA login flow support for cloud component #23188
Merged
silamon
merged 9 commits into
home-assistant:dev
from
klejejs:feat/add-support-for-mfa-cloud-login-flow
Dec 17, 2024
Merged
Add MFA login flow support for cloud component #23188
silamon
merged 9 commits into
home-assistant:dev
from
klejejs:feat/add-support-for-mfa-cloud-login-flow
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also needs to be implemented in the voice-wizard, where there is also a cloud login form |
bramkragten
reviewed
Dec 12, 2024
bramkragten
reviewed
Dec 12, 2024
bramkragten
previously approved these changes
Dec 16, 2024
…pport-for-mfa-cloud-login-flow
19 tasks
@bramkragten, the backend PR has been merged now. |
silamon
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds support for MFA login flow in the cloud component.
I wanted to make the TOTP code be auto-fillable by adding the
autocomplete="one-time-code"
property to the text field, but with my tests using 1Password, the auto-complete suggestion menu was rendered below the popup, likely due to the use of the HTML dialog by the underlying library, so I was unsure if that should be enabled if not working as expected.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: