Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MFA login flow support for cloud component #23188

Merged

Conversation

klejejs
Copy link
Contributor

@klejejs klejejs commented Dec 6, 2024

Proposed change

This PR adds support for MFA login flow in the cloud component.

I wanted to make the TOTP code be auto-fillable by adding the autocomplete="one-time-code" property to the text field, but with my tests using 1Password, the auto-complete suggestion menu was rendered below the popup, likely due to the use of the HTML dialog by the underlying library, so I was unsure if that should be enabled if not working as expected.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

This also needs to be implemented in the voice-wizard, where there is also a cloud login form

bramkragten
bramkragten previously approved these changes Dec 16, 2024
@klejejs
Copy link
Contributor Author

klejejs commented Dec 17, 2024

@bramkragten, the backend PR has been merged now.

@silamon silamon merged commit 1c076d2 into home-assistant:dev Dec 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants