Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean attributes #23189

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Fix boolean attributes #23189

merged 6 commits into from
Dec 6, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 6, 2024

Proposed change

Other required fixes after eslint PR.

Following #23182

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Supervisor Related to the supervisor panel Design Related to Home Assistant design gallery labels Dec 6, 2024
Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add this to all properties. I only added proper attribute names to properties that were used as standalone attributes.
Don't know if there is any harm though

@piitaya
Copy link
Member Author

piitaya commented Dec 6, 2024

I tried to it them for attributes that make sense. But yeah we can remove them if there are not used.

@bramkragten
Copy link
Member

There is a little performance gain when not adding the property as attribute, but it is small

@bramkragten bramkragten merged commit 6934f06 into dev Dec 6, 2024
16 checks passed
@bramkragten bramkragten deleted the fix_boolean_attributes branch December 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Related to Home Assistant design gallery Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants