Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No script entities in scenes #23192

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Dec 6, 2024

Proposed change

Scenes do not allow entities from many domains, but I see that "script" is not one of them, so I was surprised to find you can put a script inside a scene.

I do not think this is correct, since a script does not have a restorable state. I thought maybe it would run the script when the scene activates, but it does not. Seems like it doesn't do anything.

Probably best to just not have scripts be selectable here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @karwosts 👍

../Frenck

@frenck frenck merged commit df21900 into home-assistant:dev Dec 7, 2024
16 checks passed
@frenck frenck added this to the 2024.12 milestone Dec 7, 2024
@karwosts karwosts deleted the no-script-scenes branch December 7, 2024 03:47
bramkragten pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants