Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility for shown entities on device card (2) #23198

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented Dec 7, 2024

Breaking change

Proposed change

Further improvements after #22579:

  1. Currently entity rows do not look like Entities card - rows are vertically "squeezed":
    image

  2. Vertical spacing between the last row & "Show more/less button" is too much:
    image
    The difference clearly visible here:
    image

  3. Vertical spacing between enabled & disabled entities:
    image

After the fix:
image

image

image

image


Unrelated:
Imho these lines may be removed:

      .entity-id {
        color: var(--secondary-text-color);
      }
      .buttons {
        text-align: right;
        margin: 0 0 0 8px;
      }
      ...
      #entities > paper-icon-item {
        margin: 0;
      }
      paper-icon-item {
        min-height: 40px;
        padding: 0 16px;
        cursor: pointer;
        --paper-item-icon-width: 48px;
      }

Do not see how they can affect a code...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze requested a review from wendevlin December 10, 2024 11:16
@wendevlin wendevlin added the Needs UX Pull requests requiring a review from the Home Assistant design team label Dec 19, 2024
Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@wendevlin wendevlin merged commit 3b52d3d into home-assistant:dev Dec 20, 2024
17 checks passed
@ildar170975 ildar170975 deleted the device_disabled_entities branch December 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Needs UX Pull requests requiring a review from the Home Assistant design team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants