Added "Media player volume slider" card feature. #23199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Merged
8 tasks
MindFreeze
requested changes
Dec 9, 2024
src/panels/lovelace/card-features/hui-media-player-volume-card-feature.ts
Outdated
Show resolved
Hide resolved
|
TBH, I prefer buttons for volume but this is still an awesome feature |
Co-authored-by: Petar Petrov <[email protected]>
You might not be the only one. Would it make sense to call it "Media player volume slider" so a second feature called "Media player volume buttons" could be created in the future? |
|
Yeah, good idea |
simon-zumbrunnen
changed the title
MindFreeze
previously approved these changes
Dec 10, 2024
auto-merge was automatically disabled
December 10, 2024 13:07
Head branch was pushed to by a user without write access
MindFreeze
approved these changes
Dec 10, 2024
boern99
pushed a commit
to boern99/ha_frontend
that referenced
this pull request
Dec 11, 2024
* Added "Media player volume" card feature. * Make sure the feature is not displayed on unsupported players Co-authored-by: Petar Petrov <[email protected]> * Renamed to Media player volume *slider* * Missed one rename. --------- Co-authored-by: Simon Zumbrunnen <[email protected]> Co-authored-by: Petar Petrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds the possibility to add a "Media player volume" feature (slider) to the "Tile card".
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: