Correct overwriting integration labelling on integrations page #23206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately I have no experience with frontend development or testing. I hope this fixes my issue. Maybe someone can assist with testing. Also I'm not sure how to properly adapt the icon to be as here: Probably the icon should be aligned with the one here: @MindFreeze would you know? |
MindFreeze
approved these changes
Dec 8, 2024
|
Thanks! Did you have a look at https://github.com/MindFreeze/frontend/blob/9adfd802956411a57de87dd6b408473a37468170/src/panels/config/integrations/ha-integration-list-item.ts#L75, does that icon need an update as well? |
|
I think it was a design decision not to color the icons there so only the tooltip is different |
bramkragten
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Update ha-config-integration-page.ts fixes #22776 * update icon color --------- Co-authored-by: Petar Petrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This hopefully fixes #22776
Addition to #22295
https://github.com/search?q=repo%3Ahome-assistant%2Ffrontend+ui.panel.config.integrations.config_entry.custom_integration&type=code
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: